From 4b1bba8af178f4047913940d0a507b4efe7d90bf Mon Sep 17 00:00:00 2001 From: Federico Mena Quintero Date: Tue, 27 May 2008 20:33:23 +0000 Subject: [PATCH] bgo533891 - disallow DnD from the file list into itself 2008-05-27 Federico Mena Quintero http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow drag and drop from the file list into itself, as it doesn't make sense (it would just change the current folder). * gtk/gtkfilechooserdefault.c (file_list_dest_targets): Use GTK_TARGET_OTHER_WIDGET so we don't DnD from the file list into itself. Signed-off-by: Federico Mena Quintero svn path=/trunk/; revision=20194 --- ChangeLog | 10 ++++++++++ gtk/gtkfilechooserdefault.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6a1a5a9ba1..021336e0cd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2008-05-27 Federico Mena Quintero + + http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow + drag and drop from the file list into itself, as it doesn't make + sense (it would just change the current folder). + + * gtk/gtkfilechooserdefault.c (file_list_dest_targets): Use + GTK_TARGET_OTHER_WIDGET so we don't DnD from the file list into + itself. + 2008-05-27 Michael Natterer * gtk/gtksignal.h: move deprecated guards around everything, diff --git a/gtk/gtkfilechooserdefault.c b/gtk/gtkfilechooserdefault.c index 00227a8fa8..dcc28642a7 100644 --- a/gtk/gtkfilechooserdefault.c +++ b/gtk/gtkfilechooserdefault.c @@ -258,7 +258,7 @@ static const int num_file_list_source_targets = G_N_ELEMENTS (file_list_source_t /* Target types for dropping into the file list */ static const GtkTargetEntry file_list_dest_targets[] = { - { "text/uri-list", 0, TEXT_URI_LIST } + { "text/uri-list", GTK_TARGET_OTHER_WIDGET, TEXT_URI_LIST } }; static const int num_file_list_dest_targets = G_N_ELEMENTS (file_list_dest_targets); -- 2.30.2